From e456e95a0151ff050cdf6104f6fb4af812abc057 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Corr=C3=AAa=20da=20Silva=20Sanches?= Date: Thu, 5 Sep 2024 23:50:02 -0300 Subject: [PATCH] use / instead of _ on iso15008 check-IDs --- Lib/fontbakery/checks/iso15008.py | 10 +++++----- Lib/fontbakery/profiles/iso15008.py | 10 +++++----- tests/test_checks_iso15008.py | 10 +++++----- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Lib/fontbakery/checks/iso15008.py b/Lib/fontbakery/checks/iso15008.py index 61880bb1d5..b236ec707a 100644 --- a/Lib/fontbakery/checks/iso15008.py +++ b/Lib/fontbakery/checks/iso15008.py @@ -75,7 +75,7 @@ def pair_kerning(font, left, right): @check( - id="iso15008_proportions", + id="iso15008/proportions", rationale=""" According to ISO 15008, fonts used for in-car displays should not be too narrow or too wide. @@ -114,7 +114,7 @@ def check_iso15008_proportions(ttFont): @check( - id="iso15008_stem_width", + id="iso15008/stem_width", rationale=""" According to ISO 15008, fonts used for in-car displays should not be too light or too bold. @@ -146,7 +146,7 @@ def check_iso15008_stem_width(ttFont): @check( - id="iso15008_intercharacter_spacing", + id="iso15008/intercharacter_spacing", rationale=""" According to ISO 15008, fonts used for in-car displays should not be too narrow or too wide. @@ -232,7 +232,7 @@ def check_iso15008_intercharacter_spacing(font, ttFont): @check( - id="iso15008_interword_spacing", + id="iso15008/interword_spacing", rationale=""" According to ISO 15008, fonts used for in-car displays should not be too narrow or too wide. @@ -284,7 +284,7 @@ def check_iso15008_interword_spacing(font, ttFont): @check( - id="iso15008_interline_spacing", + id="iso15008/interline_spacing", rationale=""" According to ISO 15008, fonts used for in-car displays should not be too narrow or too wide. diff --git a/Lib/fontbakery/profiles/iso15008.py b/Lib/fontbakery/profiles/iso15008.py index 77bc05bb2c..b8cae57cce 100644 --- a/Lib/fontbakery/profiles/iso15008.py +++ b/Lib/fontbakery/profiles/iso15008.py @@ -1,11 +1,11 @@ PROFILE = { "sections": { "ISO15008": [ - "iso15008_intercharacter_spacing", - "iso15008_interline_spacing", - "iso15008_interword_spacing", - "iso15008_proportions", - "iso15008_stem_width", + "iso15008/intercharacter_spacing", + "iso15008/interline_spacing", + "iso15008/interword_spacing", + "iso15008/proportions", + "iso15008/stem_width", ] } } diff --git a/tests/test_checks_iso15008.py b/tests/test_checks_iso15008.py index 58b334d8bd..dfcab6bb3a 100644 --- a/tests/test_checks_iso15008.py +++ b/tests/test_checks_iso15008.py @@ -27,7 +27,7 @@ def test_extra_needed_exit(monkeypatch): def test_check_iso15008_proportions(): """Check if 0.65 => (H width / H height) => 0.80""" - check = CheckTester("iso15008_proportions") + check = CheckTester("iso15008/proportions") # Cabin has a proportion of 0.7, so that's good. font = TEST_FILE("cabin/Cabin-Regular.ttf") @@ -54,7 +54,7 @@ def test_check_iso15008_proportions(): def test_check_iso15008_stem_width(): """Check if 0.10 <= (stem width / ascender) <= 0.82""" - check = CheckTester("iso15008_stem_width") + check = CheckTester("iso15008/stem_width") font = TEST_FILE("cabin/Cabin-SemiBold.ttf") assert_PASS(check(font), "with a good font...") @@ -77,7 +77,7 @@ def test_check_iso15008_stem_width(): def test_check_iso15008_intercharacter_spacing(): """Check if spacing between characters is adequate for display use""" - check = CheckTester("iso15008_intercharacter_spacing") + check = CheckTester("iso15008/intercharacter_spacing") font = TEST_FILE("cabin/Cabin-Regular.ttf") assert_PASS(check(font), "with a good font...") @@ -113,7 +113,7 @@ def test_check_iso15008_intercharacter_spacing(): def test_check_iso15008_interword_spacing(): """Check if spacing between words is adequate for display use""" - check = CheckTester("iso15008_interword_spacing") + check = CheckTester("iso15008/interword_spacing") font = TEST_FILE("cabin/CabinCondensed-Bold.ttf") # lm space is 112; m+space+l space is 286; 286/112 = 255% @@ -128,7 +128,7 @@ def test_check_iso15008_interword_spacing(): def test_check_iso15008_interline_spacing(): """Check if spacing between lines is adequate for display use""" - check = CheckTester("iso15008_interline_spacing") + check = CheckTester("iso15008/interline_spacing") font = TEST_FILE("cabin/Cabin-Regular.ttf") assert_PASS(check(font), "with a good font...")