Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement RollingTextFileLogAdapter #37

Closed
guibranco opened this issue Jul 24, 2020 · 4 comments · Fixed by #479
Closed

[FEATURE] Implement RollingTextFileLogAdapter #37

guibranco opened this issue Jul 24, 2020 · 4 comments · Fixed by #479
Assignees
Labels
enhancement New feature or request gitauto GitAuto label to trigger the app in a issue. good first issue Good for newcomers hacktoberfest Participation in the Hacktoberfest event help wanted Extra attention is needed log .NET Pull requests that update .net code

Comments

@guibranco
Copy link
Owner

guibranco commented Jul 24, 2020

Is your feature request related to a problem? Please describe.
Implement the class RollingTextFileLogAdapter

Describe the solution you'd like
I would like to have an implementation of the Rolling Text File Log Adapter.
It should be a text file log adapter and should handle the file size/name.
A new file must be created whenever the file reaches the configured maximum size or the number of messages per file.

The rules are:

  • file size (B, MB, GB, ...)
  • quantity of messages (number of messages to roll up)
@guibranco guibranco self-assigned this Jul 29, 2020
@guibranco guibranco added the enhancement New feature or request label Jul 29, 2020
@guibranco guibranco added the log label Sep 7, 2020
@guibranco guibranco added 🛠 WIP Work in progress and removed 🛠 WIP Work in progress labels May 6, 2021
@guibranco guibranco removed their assignment Jun 30, 2023
@guibranco guibranco added the help wanted Extra attention is needed label Jun 30, 2023
@guibranco guibranco added hacktoberfest Participation in the Hacktoberfest event good first issue Good for newcomers .NET Pull requests that update .net code labels Oct 7, 2023
@guibranco guibranco changed the title Implement RollingTextFileLogAdapter Implement RollingTextFileLogAdapter Oct 25, 2023
@guibranco guibranco changed the title Implement RollingTextFileLogAdapter [FEATURE] Implement RollingTextFileLogAdapter May 15, 2024
@gitauto-ai gitauto-ai bot added the gitauto GitAuto label to trigger the app in a issue. label Jul 9, 2024
@Mohammad-Haris
Copy link
Contributor

Mohammad-Haris commented Jul 29, 2024

@guibranco I can take this one too; though I might have some questions along the way.

@guibranco
Copy link
Owner Author

Yes, sure! It has been assigned to you already. Let me know your questions...

@Mohammad-Haris
Copy link
Contributor

@guibranco In the methods where the file name is explicitly specified, like in Debug(string content, string fileName), we still have to apply the quantity of messages and file size check? Because if the max constraint is achieved the file name will be changed, e.g. a suffix might have to be added.
Also, the fileName is expected to be a complete path or just a file name?

@guibranco
Copy link
Owner Author

These Debug methods are for persisting specific content in a specific file. They don't apply to the scenario of this issue.

So, to answer your question clearly, no, it does not apply, and you can reuse it as it is on your implementation without any change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitauto GitAuto label to trigger the app in a issue. good first issue Good for newcomers hacktoberfest Participation in the Hacktoberfest event help wanted Extra attention is needed log .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants