Add missing argument to video stories #14943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
domlander
added
run_chromatic
domlander
commented
Dec 1, 2025
| sources: Source[]; | ||
| atomId: string; | ||
| uniqueId: string; | ||
| width: number; |
Contributor
Author
There was a problem hiding this comment.
height typically goes above width everywhere else.
domlander
commented
Dec 1, 2025
| export default meta; | ||
| type Story = StoryObj<typeof SelfHostedVideo>; | ||
|
|
||
| export const Loop4to5: Story = { |
Contributor
Author
There was a problem hiding this comment.
Standard cards are all in 5:4 aspect ratio
Contributor
There was a problem hiding this comment.
Fweddi
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add missing argument
videoStyleto video stories.Renames stories with wrong aspect ratio specified.
Why?
When we re-enable stories in this PR, the stories will not error.