Merge branch 'main' into jm/feat-qualify-epic-impression

Author: juabara

.github/workflows/ab-testing-checks.yml

@@ -30,19 +30,26 @@ jobs:
     steps:
       - uses: actions/checkout@v5
 
-      # https://github.com/denoland/setup-deno#latest-stable-for-a-major
-      - uses: denoland/setup-deno@v1
-        with:
-          deno-version: v2.3
+      - name: Set up Node environment
+        uses: ./.github/actions/setup-node-env
 
       - name: Test
-        run: deno test
+        run: pnpm test
+
+      - name: Lint
+        run: pnpm lint
+
+      - name: Prettier Check
+        run: pnpm prettier:check
+
+      - name: Typecheck
+        run: pnpm tsc
 
       - name: Validate
-        run: deno run scripts/validation/index.ts
+        run: pnpm validate
 
       - name: Build
-        run: deno task build
+        run: pnpm build
 
       - if: ${{ inputs.save_build_artifact }}
         uses: actions/upload-artifact@v5

.github/workflows/ab-testing-deploy.yml

@@ -26,10 +26,8 @@ jobs:
     steps:
       - uses: actions/checkout@v5
 
-      # https://github.com/denoland/setup-deno#latest-stable-for-a-major
-      - uses: denoland/setup-deno@v1
-        with:
-          deno-version: v2.3
+      - name: Set up Node environment
+        uses: ./.github/actions/setup-node-env
 
       - name: Download build artifact
         uses: actions/download-artifact@v6.0.0
@@ -38,7 +36,7 @@ jobs:
           path: ab-testing/dist
 
       - name: Deploy
-        run: deno run deploy
+        run: pnpm run deploy
         env:
           FASTLY_AB_TESTING_CONFIG: ${{ secrets.FASTLY_AB_TESTING_CONFIG }}
           FASTLY_API_TOKEN: ${{ secrets.FASTLY_API_TOKEN }}

.github/workflows/ab-testing-ui.yml

@@ -1,4 +1,4 @@
-name: 🦕 AB testing UI
+name: 🧪 AB testing UI
 on:
   pull_request:
     paths:
@@ -15,22 +15,20 @@ jobs:
   build-ui:
     name: AB testing UI build
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
     defaults:
       run:
         working-directory: ab-testing/frontend
+    permissions:
+      contents: read
     steps:
       - uses: actions/checkout@v5
 
-      # https://github.com/denoland/setup-deno#latest-stable-for-a-major
-      - uses: denoland/setup-deno@v1
-        with:
-          deno-version: v2.3
-      - name: Install
-        run: deno install
-      - name: Build
-        run: deno run build
+      - name: Set up Node environment
+        uses: ./.github/actions/setup-node-env
+
+      - name: Build UI
+        run: pnpm build
+
       - name: Save build
         uses: actions/upload-artifact@v5
         with:
@@ -41,6 +39,7 @@ jobs:
   riff-raff:
     name: AB testing Riffraff upload
     runs-on: ubuntu-latest
+    needs: build-ui
     permissions:
       id-token: write
       contents: read

.vscode/settings.json.required

@@ -2,7 +2,7 @@
 // Copy these to .vscode/settings.json to apply them to your editor – but don't commit it!
 // https://github.com/guardian/recommendations/blob/main/VSCode.md#do-not-commit-vscode
 {
-	"deno.enablePaths": ["scripts/deno", "ab-testing/scripts"],
+	"deno.enablePaths": ["scripts/deno"],
 	"deno.lint": true,
 	"deno.unstable": false,
 	"typescript.tsdk": "node_modules/typescript/lib",

ab-testing/.prettierignore

@@ -0,0 +1 @@
+frontend/.svelte-kit

ab-testing/.prettierrc

@@ -0,0 +1 @@
+{}

ab-testing/abTest.ts

@@ -0,0 +1,52 @@
+import type { ABTest } from "./types.ts";
+
+/**
+ * Tests are defined here. They will be assigned mvt ranges based on the
+ * size of the test and the number of groups, these ranges may not be contiguous.
+ *
+ * For 100% tests to run concurrently with other tests, they should be assigned to different
+ * test spaces. This means that some users will be in multiple tests at the same time.
+ *
+ * Example:
+ * [Space A]
+ * - 20% Test	control		MVT 0-99
+ * - 20% Test	variant		MVT 100-199
+ * - 50% Test	control		MVT 200-449
+ * - 50% Test	variant		MVT 450-699
+ *
+ * [Space B]
+ * - 100% Test	control		MVT 0-499
+ * - 100% Test	variant		MVT 500-999
+ */
+
+const ABTests: ABTest[] = [
+	{
+		name: "commercial-prebid-v10",
+		description: "Testing Prebid.js v10 integration on DCR",
+		owners: ["commercial.dev@guardian.co.uk"],
+		status: "ON",
+		expirationDate: "2025-12-10",
+		type: "client",
+		audienceSize: 10 / 100,
+		audienceSpace: "A",
+		groups: ["control", "variant"],
+		shouldForceMetricsCollection: true,
+	},
+	{
+		name: "commercial-user-module-ID5",
+		description:
+			"Tests whether we can get the users email, hash it and pass pd value to the userId array",
+		owners: ["commercial.dev@guardian.co.uk"],
+		expirationDate: `2025-12-19`,
+		type: "client",
+		status: "ON",
+		audienceSize: 10 / 100,
+		audienceSpace: "A",
+		groups: ["control", "variant"],
+		shouldForceMetricsCollection: true,
+	},
+];
+
+const activeABtests = ABTests.filter((test) => test.status === "ON");
+
+export { ABTests as allABTests, activeABtests };