Skip to content

Commit a7892c3

Browse files
committed
Pass trail discussionId to Card only if commentable
1 parent 4cecbf7 commit a7892c3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

dotcom-rendering/src/components/MoreGalleries.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,9 @@ const getDefaultCardProps = (
104104
dataLinkName: trail.dataLinkName,
105105
snapData: trail.snapData,
106106
discussionApiUrl,
107-
discussionId: trail.discussion?.discussionId,
107+
discussionId: trail.discussion?.isCommentable
108+
? trail.discussion.discussionId
109+
: undefined,
108110
avatarUrl: trail.avatarUrl,
109111
mainMedia: trail.mainMedia,
110112
isExternalLink: false,

dotcom-rendering/src/components/ScrollableSmallOnwards.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,9 @@ const getDefaultCardProps = (
212212
dataLinkName: trail.dataLinkName,
213213
snapData: trail.snapData,
214214
discussionApiUrl,
215-
discussionId: trail.discussion?.discussionId,
215+
discussionId: trail.discussion?.isCommentable
216+
? trail.discussion.discussionId
217+
: undefined,
216218
avatarUrl: trail.avatarUrl,
217219
mainMedia: trail.mainMedia,
218220
isExternalLink: false,

0 commit comments

Comments
 (0)