Skip to content

Commit 87633f9

Browse files
committed
update import file name paths
1 parent ab5c38f commit 87633f9

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

dotcom-rendering/src/server/lib/add-queryparams-to-abtests.ts renamed to dotcom-rendering/src/server/lib/get-abtests-from-query-params.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { Handler } from 'express';
2-
import { validateAsFEArticle } from '../../../src/model/validate';
2+
import { validateAsFEArticle } from '../../model/validate';
3+
import { logger } from './logging';
34

45
const SAFE_AB_VALUE = /^[a-zA-Z0-9_-]+$/;
56
const MAX_LENGTH = 100;
@@ -12,15 +13,12 @@ export const getABTestsFromQueryParams: Handler = async (req, res, next) => {
1213
const filteredQuery: Record<string, string> = {};
1314

1415
for (const [key, value] of Object.entries(queryParamsAb)) {
15-
// Only process AB test params
1616
if (!key.startsWith('ab-') || typeof value !== 'string') {
1717
continue;
1818
}
1919

2020
const testId = key.replace(/^ab-/, '');
2121

22-
// Validate both test ID and variant value
23-
// This prevents injection attacks and ensures safe values
2422
if (
2523
testId.length > 0 &&
2624
testId.length <= MAX_LENGTH &&
@@ -31,8 +29,7 @@ export const getABTestsFromQueryParams: Handler = async (req, res, next) => {
3129
) {
3230
filteredQuery[testId] = value;
3331
} else {
34-
// Log suspicious input for monitoring
35-
console.warn(
32+
logger.warn(
3633
`Rejected invalid AB test parameter: ${key}=${value}`,
3734
);
3835
}

dotcom-rendering/src/server/server.dev.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {
2121
handleFootballMatchPage,
2222
handleFootballTablesPage,
2323
} from './handler.sportDataPage.web';
24-
import { getABTestsFromQueryParams } from './lib/add-queryparams-to-abtests';
24+
import { getABTestsFromQueryParams } from './lib/get-abtests-from-query-params';
2525
import { getContentFromURLMiddleware } from './lib/get-content-from-url';
2626

2727
/** article URLs contain a part that looks like “2022/nov/25” */

0 commit comments

Comments
 (0)