Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug in guests_init #7

Open
didriklundberg opened this issue Aug 6, 2015 · 1 comment
Open

Potential bug in guests_init #7

didriklundberg opened this issue Aug 6, 2015 · 1 comment
Labels

Comments

@didriklundberg
Copy link
Collaborator

In init.c, in the function guests_init, you appear to loop through one extra MiB of memory when creating the one-to-one mapping of the guest memory (just below the comment "this must be a loop" around line 225). At this line, we also have the comment /+ 1 MiB at end for L1PT/. In loops on similar memory ranges below, you do not loop through extra memory. What made this stand out was also that the person who wrote the code had added SECTION_SIZE on both sides of the for-loop condition. Seems like a typical oversight...

@didriklundberg
Copy link
Collaborator Author

When Roberto tried to run the hypervisor with Linux on the Beagleboard simulator with the same memory range in the loop as in the other loops, everything seemed to work fine...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant