windows invocation

[majidaldo]

Hi Gabe.
I found an issue with the way tq is invoked on Windows.

• the stderr has "java not found" but the subprocess did not exit with a non-zero code.
• ...to fix the "java not found" issue you have to update the env that you're passing to the subprocesss env.update(os.environ).

In any case, you don't really need the windows and bash scripts as they are just setting env vars. You can have that logic in python and pass it through the env arg of subprocess.run. Also, instead of a script (string) you can just make an args sequence (or just the command as a string). This way you don't have to deal with the difference.

[majidaldo]

On a related note, even if you resolve the above, you can't really assume much about the way tq behaves. You have to check stderr and stdout for errors from the wrapper code.

[gtfierro]

HI @majidaldo! I don't have access to a Windows computer to reproduce this, so it would be great to have some help in fixing this implementation. Do you have any cycles over the next couple weeks?

[majidaldo]

HI @majidaldo! I don't have access to a Windows computer to reproduce this, so it would be great to have some help in fixing this implementation. Do you have any cycles over the next couple weeks?

ya when we get into october :)
but some preliminaries:

• why is 'brick' in the repo name? it could be called py-tq-shacl
• testing suite
• ...github has windows runners. like i mentioned, if you just use python to abstract away the differences, windows is pretty much guaranteed to work.
• i say keep the jars out of the repo but include them on build (by downloading). now this makes the python code a pure wrapper.