Skip to content

tests: Don't override the specific environment by the global one #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

stanislavlevin
Copy link
Contributor

This changes the way in which a test environment is prepared.

Before:
specific -> global

After:
global -> specific

In particular, this allows setting PATH env variable differed from
the global configuration.

Fixes: #226

This changes the way in which a test environment is prepared.

Before:
specific -> global

After:
global -> specific

In particular, this allows setting PATH env variable differed from
the global configuration.

Fixes: gssapi#226
Signed-off-by: Stanislav Levin <slev@altlinux.org>
python3-devel is required to build python-gssapi within
virtualenv.

Signed-off-by: Stanislav Levin <slev@altlinux.org>
Copy link
Contributor

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
but I see a stray commit that you also are proposing on the other PR you opened.

@stanislavlevin
Copy link
Contributor Author

This commit addresses the build issue on Fedora and it's not related to this PR, something like temp fixing commit.
If you prefer to open another ticket+PR for that let me know, I will do it.

@simo5 simo5 merged commit 731761e into gssapi:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

self-tests don't set the right PATH
2 participants