Skip to content

Commit f6d7e4f

Browse files
authored
Code cleanup and scaffolding for new Extendable mixin (dart-lang#2044)
* Add some tests to trigger crash bug * Add warning for not yet implemented and seal off comment resolution to avoid type errors * Begin implementation * Extend a timeout * warnable * Main tests pass * Finish up scaffolding and clean up * Remove an import that got added somewhere
1 parent 06ee261 commit f6d7e4f

File tree

6 files changed

+177
-160
lines changed

6 files changed

+177
-160
lines changed

bin/dartdoc.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Future<List<DartdocOption>> createDartdocProgramOptions() async {
3737
DartdocOptionArgOnly<bool>('help', false,
3838
abbr: 'h', help: 'Show command help.', negatable: false),
3939
DartdocOptionArgOnly<bool>('version', false,
40-
help: 'Display the version for $name.', negatable: false),
40+
help: 'Display the version for $programName.', negatable: false),
4141
];
4242
}
4343

lib/dartdoc.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export 'package:dartdoc/src/generator.dart';
3232
export 'package:dartdoc/src/model.dart';
3333
export 'package:dartdoc/src/package_meta.dart';
3434

35-
const String name = 'dartdoc';
35+
const String programName = 'dartdoc';
3636
// Update when pubspec version changes by running `pub run build_runner build`
3737
const String dartdocVersion = packageVersion;
3838

lib/src/markdown_processor.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -650,8 +650,7 @@ class _MarkdownCommentReference {
650650
(element as Inheritable).overriddenElement;
651651
while (overriddenElement != null) {
652652
tryClasses.add(
653-
((element as Inheritable).overriddenElement as EnclosedElement)
654-
.enclosingElement);
653+
(element as Inheritable).overriddenElement.enclosingElement);
655654
overriddenElement = overriddenElement.overriddenElement;
656655
}
657656
}

0 commit comments

Comments
 (0)