Skip to content

Commit 0de85dd

Browse files
committed
feat: improve flattern registry name
1 parent c5e9d8e commit 0de85dd

File tree

3 files changed

+49
-5
lines changed

3 files changed

+49
-5
lines changed

internal/app/gitops-commit/slackhttp/model.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ func (c *NamedRepositoryRegistry) getNamesFlattened() string {
5252
var names string
5353

5454
for _, r := range *c.r {
55-
names += r.Name + ","
55+
names += r.Name + ", "
5656
}
5757

58-
return names[:len(names)-1]
58+
return names[:len(names)-2]
5959
}
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
package slackhttp
2+
3+
import "testing"
4+
5+
func TestNamedRepositoryRegistry_getNamesFlattened(t *testing.T) {
6+
type fields struct {
7+
r *[]NamedRepository
8+
}
9+
tests := []struct {
10+
name string
11+
fields fields
12+
want string
13+
}{
14+
{
15+
name: "gg",
16+
fields: fields{
17+
r: &[]NamedRepository{
18+
{
19+
Name: "repo1",
20+
Repository: "test",
21+
File: "test",
22+
Notation: "test",
23+
Branch: "master",
24+
},
25+
{
26+
Name: "repo2",
27+
Repository: "test",
28+
File: "test",
29+
Notation: "test",
30+
Branch: "master",
31+
},
32+
},
33+
},
34+
want: "repo1, repo2",
35+
},
36+
}
37+
for _, tt := range tests {
38+
t.Run(tt.name, func(t *testing.T) {
39+
c := &NamedRepositoryRegistry{
40+
r: tt.fields.r,
41+
}
42+
if got := c.getNamesFlattened(); got != tt.want {
43+
t.Errorf("getNamesFlattened() = %v, want %v", got, tt.want)
44+
}
45+
})
46+
}
47+
}

internal/pkg/gitops/version_test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package gitops
22

33
import (
4-
"fmt"
54
"gopkg.in/yaml.v3"
65
"testing"
76
)
@@ -74,8 +73,6 @@ func TestReadCurrentVersion(t *testing.T) {
7473
},
7574
}
7675

77-
fmt.Println(string(createSimpleArrayYaml("v1.2.99")))
78-
7976
for _, tt := range tests {
8077
t.Run(tt.name, func(t *testing.T) {
8178
got, err := ReadCurrentVersion(tt.args.f, tt.args.notation)

0 commit comments

Comments
 (0)