Standardizing dependencies to a list input #32
Conversation
|
I think Yori changed to using |
rileykarson
left a comment
rileykarson
left a comment
There was a problem hiding this comment.
LGTM other than that^
|
Ah! The perils of distributed team! Sorry I felt that That said, I do not feel strongly about the name. Both are good to me. Given that, let's use All that to say, @autero1 don't change your implementation! |
| resource "null_resource" "dependency_getter" { | ||
| provisioner "local-exec" { | ||
| command = "echo ${length(var.dependencies)}" | ||
| } |
There was a problem hiding this comment.
Did you run into issues with the triggers approach? Should I switch back to this method too?
There was a problem hiding this comment.
I ended up using the local-exec eventually. Switching back and forth was just trying to see if that made the tests more stable. Turned out it didn't make a difference - root cause was most likely just instability with the GCP APIs.
As discussed in gruntwork-io/terraform-kubernetes-helm#25, this PR used a list variable
dependenciesto implement module dependencies.