Skip to content

Must have struct for json to work, not nil #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Conversation

yorinasub17
Copy link
Contributor

@yorinasub17 yorinasub17 commented Jul 14, 2022

Description

Fixes a bug in the new github package to properly handle the json unmarshal. It turns out using a nil uninitialized pointer is not supported (leads to the following runtime error):

Error loading configured Github App Config JSON: json: Unmarshal(nil *github.GithubAppConfig)

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner July 14, 2022 17:57
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit 3f0ebb8 into master Jul 14, 2022
@yorinasub17 yorinasub17 deleted the bug/fix-parsing branch July 14, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants