From 1d8805074e6fc7188bd9315ea591e915d83dbdc6 Mon Sep 17 00:00:00 2001 From: Vlad Filippov Date: Sat, 28 Jan 2023 20:20:56 -0500 Subject: [PATCH] Bump eslint and node version --- .github/workflows/test.yml | 2 +- CHANGELOG | 5 +++ Gruntfile.js | 16 ++++---- package.json | 6 +-- test/gruntfile/multi-task-files.js | 62 +++++++++++++++--------------- 5 files changed, 48 insertions(+), 43 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 821633742..a996abf14 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: false matrix: - node: [12, 14, 16] + node: [14, 16, 18] os: [ubuntu-latest, windows-latest] steps: diff --git a/CHANGELOG b/CHANGELOG index 17bb4b7f1..a58f931d7 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,8 @@ +v1.6.0 + date: 2023-01-28 + changes: + - Requires node.js 14+. + - v1.5.3 date: 2022-04-23 changes: diff --git a/Gruntfile.js b/Gruntfile.js index c0519abe2..8cfc6470e 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -15,18 +15,18 @@ module.exports = function(grunt) { } }, eslint: { - gruntfile_tasks: ['Gruntfile.js', 'internal-tasks/*.js'], - libs_n_tests: ['lib/**/*.js', '<%= nodeunit.all %>'], + gruntfileTasks: ['Gruntfile.js', 'internal-tasks/*.js'], + libsAndTests: ['lib/**/*.js', '<%= nodeunit.all %>'], subgrunt: ['<%= subgrunt.all %>'] }, watch: { - gruntfile_tasks: { - files: ['<%= eslint.gruntfile_tasks %>'], - tasks: ['eslint:gruntfile_tasks'] + gruntfileTasks: { + files: ['<%= eslint.gruntfileTasks %>'], + tasks: ['eslint:gruntfileTasks'] }, - libs_n_tests: { - files: ['<%= eslint.libs_n_tests %>'], - tasks: ['eslint:libs_n_tests', 'nodeunit'] + libsAndTests: { + files: ['<%= eslint.libsAndTests %>'], + tasks: ['eslint:libsAndTests', 'nodeunit'] }, subgrunt: { files: ['<%= subgrunt.all %>'], diff --git a/package.json b/package.json index 1343da150..201048ef9 100644 --- a/package.json +++ b/package.json @@ -7,7 +7,7 @@ "repository": "https://github.com/gruntjs/grunt.git", "license": "MIT", "engines": { - "node": ">=8" + "node": ">=14" }, "scripts": { "test": "node bin/grunt test", @@ -55,10 +55,10 @@ }, "devDependencies": { "difflet": "~1.0.1", - "eslint-config-grunt": "~1.0.1", + "eslint-config-grunt": "~2.0.1", "grunt-contrib-nodeunit": "~4.0.0", "grunt-contrib-watch": "~1.1.0", - "grunt-eslint": "~18.1.0", + "grunt-eslint": "~24.0.1", "temporary": "~0.0.4", "through2": "~4.0.2" }, diff --git a/test/gruntfile/multi-task-files.js b/test/gruntfile/multi-task-files.js index d170d062d..3a519f649 100644 --- a/test/gruntfile/multi-task-files.js +++ b/test/gruntfile/multi-task-files.js @@ -59,7 +59,7 @@ module.exports = function(grunt) { ] }, // File mapping options can be specified in these 2 formats. - built_mapping: { + builtMapping: { options: {a: 6, c: 66}, expand: true, cwd: '<%= mappings.cwd %>', @@ -68,7 +68,7 @@ module.exports = function(grunt) { rename: '<%= mappings.rename %>', extra: 123 }, - long3_mapping: { + long3Mapping: { options: {a: 7, c: 77}, files: [ { @@ -81,22 +81,22 @@ module.exports = function(grunt) { } ] }, - long4_mapping: { + long4Mapping: { options: {a: 8, c: 88}, files: [ - '<%= run.long3_mapping.files %>' + '<%= run.long3Mapping.files %>' ] }, - long5_mapping: { + long5Mapping: { options: {a: 9, c: 99}, files: [ - '<%= run.long3_mapping.files %>', - '<%= run.long4_mapping.files %>' + '<%= run.long3Mapping.files %>', + '<%= run.long4Mapping.files %>' ] }, // Need to ensure the task function is run if no files or options were // specified! - no_files_or_options: {}, + noFilesOrOptions: {}, }, }); @@ -124,7 +124,7 @@ module.exports = function(grunt) { }); var expecteds = { - 'run:no_files_or_options': { + 'run:noFilesOrOptions': { options: {a: 1, b: 11, d: 9}, files: [], }, @@ -236,7 +236,7 @@ module.exports = function(grunt) { }, ], }, - 'run:built_mapping': { + 'run:builtMapping': { options: {a: 6, b: 11, c: 66, d: 9}, files: [ { @@ -248,7 +248,7 @@ module.exports = function(grunt) { cwd: grunt.config.get('mappings.cwd'), src: ['*1.js', '*2.js'], dest: grunt.config.get('mappings.dest'), - rename: grunt.config.get('run.built_mapping.rename'), + rename: grunt.config.get('run.builtMapping.rename'), extra: 123, }, }, @@ -258,16 +258,16 @@ module.exports = function(grunt) { extra: 123, orig: { expand: true, - cwd: grunt.config.get('run.built_mapping.cwd'), + cwd: grunt.config.get('run.builtMapping.cwd'), src: ['*1.js', '*2.js'], - dest: grunt.config.get('run.built_mapping.dest'), - rename: grunt.config.get('run.built_mapping.rename'), + dest: grunt.config.get('run.builtMapping.dest'), + rename: grunt.config.get('run.builtMapping.rename'), extra: 123, }, }, ], }, - 'run:long3_mapping': { + 'run:long3Mapping': { options: {a: 7, b: 11, c: 77, d: 9}, files: [ { @@ -292,13 +292,13 @@ module.exports = function(grunt) { cwd: grunt.config.get('mappings.cwd'), src: ['*1.js', '*2.js'], dest: grunt.config.get('mappings.dest'), - rename: grunt.config.get('run.built_mapping.rename'), + rename: grunt.config.get('run.builtMapping.rename'), extra: 123, }, }, ], }, - 'run:long4_mapping': { + 'run:long4Mapping': { options: {a: 8, b: 11, c: 88, d: 9}, files: [ { @@ -323,13 +323,13 @@ module.exports = function(grunt) { cwd: grunt.config.get('mappings.cwd'), src: ['*1.js', '*2.js'], dest: grunt.config.get('mappings.dest'), - rename: grunt.config.get('run.built_mapping.rename'), + rename: grunt.config.get('run.builtMapping.rename'), extra: 123, }, }, ], }, - 'run:long5_mapping': { + 'run:long5Mapping': { options: {a: 9, b: 11, c: 99, d: 9}, files: [ { @@ -354,7 +354,7 @@ module.exports = function(grunt) { cwd: grunt.config.get('mappings.cwd'), src: ['*1.js', '*2.js'], dest: grunt.config.get('mappings.dest'), - rename: grunt.config.get('run.built_mapping.rename'), + rename: grunt.config.get('run.builtMapping.rename'), extra: 123, }, }, @@ -380,7 +380,7 @@ module.exports = function(grunt) { cwd: grunt.config.get('mappings.cwd'), src: ['*1.js', '*2.js'], dest: grunt.config.get('mappings.dest'), - rename: grunt.config.get('run.built_mapping.rename'), + rename: grunt.config.get('run.builtMapping.rename'), extra: 123, }, }, @@ -427,8 +427,8 @@ module.exports = function(grunt) { }); grunt.registerTask('default', [ - 'run:no_files_or_options', - 'test:no_files_or_options', + 'run:noFilesOrOptions', + 'test:noFilesOrOptions', 'run:dist/built.js', 'test:dist/built.js', 'run:dist/built1.js', @@ -441,14 +441,14 @@ module.exports = function(grunt) { 'test:long2', 'run:long3', 'test:long3', - 'run:built_mapping', - 'test:built_mapping', - 'run:long3_mapping', - 'test:long3_mapping', - 'run:long4_mapping', - 'test:long4_mapping', - 'run:long5_mapping', - 'test:long5_mapping', + 'run:builtMapping', + 'test:builtMapping', + 'run:long3Mapping', + 'test:long3Mapping', + 'run:long4Mapping', + 'test:long4Mapping', + 'run:long5Mapping', + 'test:long5Mapping', 'run', 'test:all', 'test:counters',