Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined should not be counted as value? #29

Open
pySilver opened this issue Sep 19, 2019 · 2 comments
Open

Undefined should not be counted as value? #29

pySilver opened this issue Sep 19, 2019 · 2 comments

Comments

@pySilver
Copy link

Consider the case:

  • 3 stores (cookie, localstorage, indexdb) are used.
  • 2 out of 3 loses value (no matter which).
  • Value counter makes 3rd value disappear too, since "undefined" response from first storages is treated as some value.

Expected behaviour: value will be recreated in 2 stores that returned undefined.

@gruns
Copy link
Owner

gruns commented Sep 20, 2019

Wonderful suggestion.

A sentinel value should be used instead of undefined.

@gruns
Copy link
Owner

gruns commented Aug 20, 2020

#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants