Fix child resolve for types with generic interfaces #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemyjski
requested changes
May 19, 2020
| @@ -13,6 +13,12 @@ | |||
| // FITNESS FOR A PARTICULAR PURPOSE. | |||
| //=============================================================================== | |||
|
|
|||
| #region Preprocessor Directives | |||
|
|
|||
| #define RESOLVE_OPEN_GENERICS // Platform supports resolving open generics | |||
There was a problem hiding this comment.
Can this get moved to the csproj
| @@ -3716,23 +3716,26 @@ private ObjectFactoryBase GetParentObjectFactory(TypeRegistration registration) | |||
|
|
|||
| ObjectFactoryBase factory; | |||
|
|
|||
| if (_Parent._RegisteredTypes.TryGetValue(registration, out factory)) | |||
There was a problem hiding this comment.
Any idea why this was moved out? It would be nice to have additional test coverage for any changes.
|
Thanks for the PR, I see there is a test for this but not sure why |
|
@joaomsa can you please check out my feedback and questions. |
|
@joaomsa can you please check out my feedback and questions. |
|
Sorry about the delay, but we no longer use TinyIoC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #127 , when attempting to resolve an open generic type from a child container it would fail to lookup for the generic definition in the parent container.
There was already a test covering just this case in
https://github.com/grumpydev/TinyIoC/blob/master/tests/TinyIoC.Tests/TinyIoCTests.cs#L3367
but because it was within a RESOLVE_OPEN_GENERICS region with that directive never being set it was failing.
Not sure how your testing matrix is setup but now that I've added the directive to the file header it runs those tests properly.
This also resolves #128