fix input scalar in typed debugger window issue #1295

[xcasadio]

Fixed this issue #1295

• Input scalar has unique ID
• Input scalar has unique value
• removed the unnecessary string "--" when input scalar is displayed

[coderabbitai]

Walkthrough

The changes update the input handling for memory editing in the typed debugger widget. The code now tracks new values per memory address using a map, modifies the displayNewValueInput method signature to include an address parameter and pass memory file by reference, and updates the UI logic to reflect these adjustments.

Changes

File(s)	Change Summary
src/gui/widgets/typed_debugger.cc	Refactored displayNewValueInput to accept address and memory file by reference; tracks new values per address using a map; updated UI logic and input widget IDs; removed disabled text after input.
src/gui/widgets/typed_debugger.h	Replaced single m_newValue with m_newValues map; updated displayNewValueInput signature to match new parameters.

Possibly related PRs

• Several fixes and improvements to the typed debugger #1865: Memory access refactoring and input handling improvements in TypedDebugger that laid groundwork for per-address input state management.

Poem

A nibble, a hop, a byte to tweak,
Now each address has its own unique peek!
With maps for values, and widgets anew,
Debugging memory is easier to do.
Rabbits rejoice as the code refines—
Each address tracked, across the lines!
🐇💾✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 085afc0 and 41a85be.

📒 Files selected for processing (1)

• src/gui/widgets/typed_debugger.cc (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/gui/widgets/typed_debugger.cc

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This PR fixes the input scalar display issue by ensuring each input scalar gets a unique ID and value, and by removing the redundant "--" output.

• Updated member variable from a single new value to an address-keyed map (m_newValues).
• Changed the signature of displayNewValueInput to include the address parameter and updated its implementation accordingly.
• Removed the unnecessary string "--" when displaying the input scalar.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/gui/widgets/typed_debugger.h	Updated member variable and function signature for input scalar handling
src/gui/widgets/typed_debugger.cc	Modified input scalar logic to use m_newValues and removed redundant output