Skip to content

Commit 2a273f6

Browse files
authored
Merge pull request #164 from asmblur/mips-asm-warnings-fixes
Fix some warnings.
2 parents ad25507 + 45242e4 commit 2a273f6

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

src/mips/openbios/boot/boot.s

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ _boot:
9595
sw $t0, SBUS_DEV8_CTRL
9696

9797
/* clearing out all registers */
98+
.set push
99+
.set noat
98100
move $1, $0
101+
.set pop
99102
move $2, $0
100103
move $3, $0
101104
move $4, $0

src/mips/openbios/kernel/handlers.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ void A0Vector();
2727
void B0Vector();
2828
void C0Vector();
2929

30-
__attribute__((section(".a0table"))) uint32_t A0table[0xc0] = {
30+
__attribute__((section(".a0table"))) void * A0table[0xc0] = {
3131
unimplemented, unimplemented, unimplemented, unimplemented, // 00
3232
unimplemented, unimplemented, unimplemented, unimplemented, // 04
3333
unimplemented, unimplemented, unimplemented, unimplemented, // 08
@@ -78,7 +78,7 @@ __attribute__((section(".a0table"))) uint32_t A0table[0xc0] = {
7878
unimplemented, unimplemented, unimplemented, unimplemented, // bc
7979
};
8080

81-
uint32_t B0table[0x60] = {
81+
void *B0table[0x60] = {
8282
unimplemented, unimplemented, unimplemented, unimplemented, // 00
8383
unimplemented, unimplemented, unimplemented, unimplemented, // 04
8484
unimplemented, unimplemented, unimplemented, unimplemented, // 08
@@ -105,7 +105,7 @@ uint32_t B0table[0x60] = {
105105
unimplemented, unimplemented, unimplemented, unimplemented, // 5c
106106
};
107107

108-
uint32_t C0table[0x20] = {
108+
void * C0table[0x20] = {
109109
unimplemented, unimplemented, unimplemented, unimplemented, // 00
110110
unimplemented, unimplemented, unimplemented, unimplemented, // 04
111111
unimplemented, unimplemented, unimplemented, unimplemented, // 08
@@ -116,11 +116,11 @@ uint32_t C0table[0x20] = {
116116
unimplemented, unimplemented, unimplemented, unimplemented, // 1c
117117
};
118118

119-
static void installHandler(const uint32_t * src, uint32_t * dst) {
120-
dst[0] = src[0];
121-
dst[1] = src[1];
122-
dst[2] = src[2];
123-
dst[3] = src[3];
119+
static void installHandler(const void * src, void * dst) {
120+
((uint32_t *) dst)[0] = ((uint32_t *) src)[0];
121+
((uint32_t *) dst)[1] = ((uint32_t *) src)[1];
122+
((uint32_t *) dst)[2] = ((uint32_t *) src)[2];
123+
((uint32_t *) dst)[3] = ((uint32_t *) src)[3];
124124
}
125125

126126
void installKernelHandlers() {

src/mips/openbios/kernel/vectors.s

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *
1818
***************************************************************************/
1919

20+
.set push
2021
.set noreorder
2122
.section .data, "ax", @progbits
2223
.align 2
@@ -25,7 +26,10 @@
2526

2627
generalHandler:
2728
sw $0, 0x100($0)
29+
.set push
30+
.set noat
2831
sw $1, 0x104($0)
32+
.set pop
2933
sw $2, 0x108($0)
3034
sw $3, 0x10c($0)
3135
sw $4, 0x110($0)
@@ -92,7 +96,10 @@ generalHandler:
9296
nop
9397
mtc0 $t3, $13
9498
nop
99+
.set push
100+
.set noat
95101
lw $1, 0x104($0)
102+
.set pop
96103
lw $2, 0x108($0)
97104
lw $3, 0x10c($0)
98105
lw $4, 0x110($0)
@@ -227,3 +234,5 @@ unimplemented:
227234
nop
228235
jr $ra
229236
nop
237+
238+
.set pop

0 commit comments

Comments
 (0)