A72 update: various clarifications and corrections #474
+28
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes -
previous-rpc-attempts
does not include transparent retries as per https://github.com/grpc/proposal/blob/master/A45-retry-stats.mdsequence-number
attribute from events in examples.sent
andreceived
words fromInbound message received
andOutbound message sent
. Reasoning -Inbound
andOutbound
already convey the direction. The way it is currently structured, you could haveOutbound message sent
followed byOutbound message compressed
, andInbound compressed message
followed byInbound message received
. In the future, we might want additional events (especially for C++) for when we know that bytes have actually been sent on the wire.