Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A72 update: various clarifications and corrections #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Feb 6, 2025

Changes -

  • Add link to OpenCensus's binary format for grpc-trace-bin
  • Add names for parent call span, attempt span and server span based on existing OpenCensus implementation.
  • Clarify previous-rpc-attempts does not include transparent retries as per https://github.com/grpc/proposal/blob/master/A45-retry-stats.md
  • Add missing sequence-number attribute from events in examples.
  • Remove superfluous and confusing sent and received words from Inbound message received and Outbound message sent. Reasoning - Inbound and Outbound already convey the direction. The way it is currently structured, you could have Outbound message sent followed by Outbound message compressed , and Inbound compressed message followed by Inbound message received. In the future, we might want additional events (especially for C++) for when we know that bytes have actually been sent on the wire.

@yashykt
Copy link
Member Author

yashykt commented Feb 6, 2025

cc @markdroth @dfawley

Copy link
Contributor

@YifeiZhuang YifeiZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markdroth markdroth changed the title A72 clarifications and corrections A72 update: various clarifications and corrections Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants