Skip to content

Commit 244dfce

Browse files
Update A91-outlier-detection-metrics.md
Changed Detected ejections to Unenforced ejections
1 parent 813e453 commit 244dfce

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

A91-outlier-detection-metrics.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ The following metrics will be exported:
5050
| grpc.lb.outlier_detection.ejections_enforced | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Total enforced ejections due to any outlier type |
5151
| grpc.lb.outlier_detection.ejections_overflow | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Number of ejections aborted due to max ejection percentage |
5252
| grpc.lb.outlier_detection.ejections_enforced_success_rate | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Enforced success rate outlier ejections |
53-
| grpc.lb.outlier_detection.ejections_detected_success_rate | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Detected (even if unenforced) success rate outlier ejections |
53+
| grpc.lb.outlier_detection.ejections_unenforced_success_rate | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Unenforced success rate outlier ejections due to either max ejection percentage or enforcement_percentage |
5454
| grpc.lb.outlier_detection.ejections_enforced_failure_percentage | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Enforced failure percentage outlier ejections |
55-
| grpc.lb.outlier_detection.ejections_detected_failure_percentage | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Detected (even if unenforced) failure percentage outlier ejections |
55+
| grpc.lb.outlier_detection.ejections_unenforced_failure_percentage | Counter | {ejection} | grpc.target, grpc.lb.backend_service | Unenforced failure percentage outlier ejections due to either max ejection percentage or enforcement_percentage |
5656

5757
On any detection and ejection/unejection, these metrics will be accordingly updated.
5858

@@ -70,6 +70,8 @@ The metrics defined here are generally a trade-off between the usefulness
7070
of the metric and the cost of reporting it. As the design goal is offering parity to envoy metrics,
7171
we decided to include any metric that was appropriate to gRPC outlier detection.
7272

73+
One change from envoy metrics was instead of reporting all detected ejections (enforced or unenforced) for each algorithm type as its own metric, we opted to simply report enforced and unenforced ejections separately. This reduces cost of any detected outlier by 1 metric in the enforced case, and the unenforced count is more likely the direct information a user of the "detected" metric in Envoy is seeking.
74+
7375
## Implementation
7476

7577
Dropbox is able to contribute towards a Core and Go implementation, in that order. Implementation of remaining gRPC languages is left for respective gRPC team or other contributors.

0 commit comments

Comments
 (0)