Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport notifications for Ruby on Rails #21164

Closed
danielmbarlow opened this issue Nov 13, 2019 · 3 comments
Closed

ActiveSupport notifications for Ruby on Rails #21164

danielmbarlow opened this issue Nov 13, 2019 · 3 comments

Comments

@danielmbarlow
Copy link

I looked for a specific Ruby repository to see if I should post this there, but didn't find one.

Is your feature request related to a problem? Please describe.

We need see how much time our Ruby on Rails application is taking on gRPC requests. In particular we're using the GoogleAds gem.

Describe the solution you'd like

I would like to be able to configure gRPC to provide ActiveSupport notifications like we get from the Excon HTTP library. Please see their documentation about that functionality. We found it very easy to use.

Describe alternatives you've considered

  • I looked to see if InterceptorRegistry was available to callers, but it's internal to gRPC.
  • I also checked our main interest in gRPC tracing: the GoogleAdsRuby gem. It implements interceptors. However it doesn't make the interceptor API public or provide ActiveSupport notifications
@stale
Copy link

stale bot commented Aug 3, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@stale stale bot closed this as completed Aug 11, 2020
@houstonheat
Copy link

houstonheat commented Feb 22, 2022

Same here, I am also interested in this.
@danielmbarlow Can you please tell me the solution you ended up with?

@danielmbarlow
Copy link
Author

We wanted active support notifications because that would enable tracing in OpenCensus. In the end I don't think we really got a solution. However we are moving to OpenTelemetry. I haven't looked into it much, but there is an unfinished PR to implement gRpc instrumentation using OpenTelemetry:

open-telemetry/opentelemetry-ruby#854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants