-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CommonJS style imports for closure_grpc_web_library #260
Conversation
Unfortunately, this won't work, and I think it will be confusing if we have this option. |
In what way won't this work? It does generate |
Yes, it does generate Adding a flag to
|
@Yannic So I patched in this PR. And then I modified this BUILD rule: https://github.com/grpc/grpc-web/blob/master/net/grpc/gateway/examples/echo/BUILD.bazel#L10 to become:
It builds properly with no error. It outputs a Yes the resulting file has this line
But that's up to the user of this BUILD rule on how to integrate right? They may have another rule that outputs |
(Sorry, longish answer incoming) Yeah, the Assume we have the following build graph (yellow targets are generated by aspects): I hope this explains why it's not as easy to support Regarding the |
It's similar to how
closure_js_proto_library
supports different import stylescc @oferb