Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds protoc from source #967

Closed
alexeagle opened this issue Oct 1, 2020 · 2 comments
Closed

Builds protoc from source #967

alexeagle opened this issue Oct 1, 2020 · 2 comments

Comments

@alexeagle
Copy link

I updated to latest rules_proto to pick up this brilliant work
bazelbuild/rules_proto#36
which means I can build proto_library targets without needing a working C++ compile toolchain on the machine (some devs at my company have incompatible protobuf header files on the LD_PATH for example)

However even with v1.2.1 of grpc_web, it is building @com_github_protocolbuffers_protobuf//:protoc_lib from source.
I think that's because the grpc bits are built into the cc_binary
https://github.com/grpc/grpc-web/blob/master/javascript/net/grpc/web/BUILD.bazel#L11

Is there a way to do this without building protoc from source? Can this be formulated as a plugin to the pre-built protoc instead?
/cc @Yannic hi! looks like you've been working in this area

@Yannic
Copy link
Contributor

Yannic commented Oct 1, 2020

The good news is that, as of #872, using a custom (pre-build) plugin is feasible. The bad news is that I won't have time to work on it anytime soon.

If you (or anyone else interested in it) want to contribute this, I'm happy to provide some guidance and help with the review! Let me know what you think.

@sampajano
Copy link
Collaborator

Thanks for the discussions :) I'm closing this now since i believe this is legacy now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants