Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript generated ToObject types doesn't work with nested types #500

Closed
johnmillage opened this issue Mar 19, 2019 · 2 comments
Closed

Comments

@johnmillage
Copy link

I you have nested types in your .proto file the .d.ts typescript files will generate the AsObject type helpers incorectly. They will have nested types as there actual message type instead of the corresponding AsObject type. The javascript works correctly so this is just an issue with the typescript generation.

@stanley-cheung
Copy link
Collaborator

This might have been fixed via #430? I am not entire sure. It probably doesn't. But just in case, can you check the released version of 1.0.4 to see if the issue is fixed?

@shaxbee
Copy link
Contributor

shaxbee commented Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants