Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated TypeScript typings should extend google-protobuf typings #488

Closed
neilcarpenter opened this issue Mar 1, 2019 · 2 comments
Closed

Generated TypeScript typings should extend google-protobuf typings #488

neilcarpenter opened this issue Mar 1, 2019 · 2 comments

Comments

@neilcarpenter
Copy link

Currently typings generated for proto messages only include getters/setters to proto message fields, but do not include typings for inherited methods from jspb.Message, resulting in TypeScript compiler errors when trying to use Message methods.

Discovered this when trying to use Message.clone().
@stanley-cheung
Copy link
Collaborator

I believe this is fixed in master via #444

@stanley-cheung
Copy link
Collaborator

This should be fixed in release 1.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neilcarpenter @stanley-cheung