Log message when no TLS SNI extension value set

Author: esen

Sources/GRPC/ClientConnection.swift

@@ -361,7 +361,7 @@ extension ClientConnection {
     logger: Logger
   ) -> ClientBootstrapProtocol {
     // Provide a server hostname if we're using TLS. Prefer the override.
-    let serverHostname: String? = configuration.tls.map {
+    var serverHostname: String? = configuration.tls.map {
       if let hostnameOverride = $0.hostnameOverride {
         logger.debug("using hostname override for TLS", metadata: ["server-hostname": "\(hostnameOverride)"])
         return hostnameOverride
@@ -371,6 +371,11 @@ extension ClientConnection {
         return host
       }
     }
+    
+    if let hostname = serverHostname, hostname.isIPAddress {
+      logger.debug("IP address cannot be used for TLS SNI extension. No host used", metadata: ["server-hostname": "nil"])
+      serverHostname = nil
+    }
 
     let bootstrap = PlatformSupport.makeClientBootstrap(group: eventLoop)
       // Enable SO_REUSEADDR and TCP_NODELAY.
@@ -540,7 +545,7 @@ fileprivate extension Channel {
     do {
       let sslClientHandler = try NIOSSLClientHandler(
         context: try NIOSSLContext(configuration: configuration),
-        serverHostname: serverHostname.flatMap { $0.isIPAddress ? nil : $0 }
+        serverHostname: serverHostname
       )
 
       return self.pipeline.addHandlers(sslClientHandler, TLSVerificationHandler())
@@ -578,14 +583,14 @@ extension HTTP2ToHTTP1ClientCodec.HTTPProtocol {
 }
 
 fileprivate extension String {
-    var isIPAddress: Bool {
-        // We need some scratch space to let inet_pton write into.
-        var ipv4Addr = in_addr()
-        var ipv6Addr = in6_addr()
-
-        return self.withCString { ptr in
-            return inet_pton(AF_INET, ptr, &ipv4Addr) == 1 ||
-                   inet_pton(AF_INET6, ptr, &ipv6Addr) == 1
-        }
+  var isIPAddress: Bool {
+    // We need some scratch space to let inet_pton write into.
+    var ipv4Addr = in_addr()
+    var ipv6Addr = in6_addr()
+    
+    return self.withCString { ptr in
+      return inet_pton(AF_INET, ptr, &ipv4Addr) == 1 ||
+        inet_pton(AF_INET6, ptr, &ipv6Addr) == 1
     }
+  }
 }