Skip to content

Conversation

@JustinBeckwith
Copy link
Contributor

This was causing compilation errors with Node.js 10 in nodejs-common-grpc.

cc @alexander-fenster

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@JustinBeckwith
Copy link
Contributor Author

I signed it!

@JustinBeckwith
Copy link
Contributor Author

Rad. I don't have merge rights on this repo, so one of y'all need to :)

@nicolasnoble nicolasnoble merged commit bee673f into grpc:v1.11.x May 3, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants