-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-js: Improve reporting of HTTP error codes #2723
Merged
murgatroid99
merged 1 commit into
grpc:@grpc/grpc-js@1.10.x
from
murgatroid99:grpc-js_http2_error_reporting
May 1, 2024
Merged
grpc-js: Improve reporting of HTTP error codes #2723
murgatroid99
merged 1 commit into
grpc:@grpc/grpc-js@1.10.x
from
murgatroid99:grpc-js_http2_error_reporting
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Apr 30, 2024
This was referenced May 23, 2024
This was referenced Jun 2, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 18, 2024
This was referenced Jun 20, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a couple of changes to HTTP status code handling:
I also added some information to the "RST_STREAM with code 0" error to explain what it means semantically, and I had to refactor
handleTrailers
. That refactor does change the behavior slightly, mainly to prioritize the gRPC status over the HTTP status when provided, which I think is more correct behavior.