Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: Replace ctx.host_configuration with ctx.configuration #9742

Merged
merged 1 commit into from
Dec 14, 2022
Merged

bazel: Replace ctx.host_configuration with ctx.configuration #9742

merged 1 commit into from
Dec 14, 2022

Conversation

gregestren
Copy link
Contributor

@gregestren gregestren commented Dec 8, 2022 •
edited by sergiitk
Loading

Replace ctx.host_configuration.host_path_separator with ctx.configuration.host_path_separator.

This is because

  1. we're removing ctx.host_configuration
  2. host_path_separator's value doesn't depend on the configuration (the API is misleading by embedding it under ctx.configuration). So this is a no-op.

Internal ref cl/494008561.

@gregestren
Replace ctx.host_configuration.host_path_separator with ctx.configura…
208009f 
…tion.host_path_separator.

This is because

1. we're removing ctx.host_configuration
2. host_path_separator's value doesn't depend on the configuration (the API is misleading by embedding it under ctx.configuration). So this is a no-op.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 8, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: gregestren / name: Greg (208009f)

@sergiitk sergiitk added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 14, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Dec 14, 2022
@sergiitk sergiitk changed the title Replace ctx.host_configuration.host_path_separator with ctx.configura… bazel: Replace ctx.host_configuration with ctx.configuration Dec 14, 2022
@sergiitk
Copy link
Member

Tested:

bazel build //grpclb:grpclb
bazel build //compiler:java_grpc_library_toolchain
bazel build //compiler:grpc_java_plugin
bazel build '//compiler:*'

@sergiitk sergiitk merged commit e325dc9 into grpc:master Dec 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregestren @sergiitk @grpc-kokoro