-
Notifications
You must be signed in to change notification settings - Fork 3.9k
add examples of name resolve and load balance #9700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This error happened when I use LoadBalanceClient which was compiled by Bazel, but Maven and Gradle are normal, I don't know how to fix it, can someone give a help? |
Sorry for the delay in reviewing this! It's looking great, thanks for the extra effort to have it match the Go implementation. Could we do one more change to have it match Go even closer? If you look at the Go codebase they have split this into two independent examples, "name_resolving" and "load_balancing". The idea is that a user wanting to just understand load balancing does not get confused with custom name resolution code and think they have to implement that as well. You may have been hesitant to split the examples because both examples use the same server code, but in this case it would be fine to just copy the same implementation to both examples. |
Thank you @Smityz this looks great! |
Ref: #9691
I add an example of name resolve and load balance.