Skip to content

ManagedChannelImpl.SubchannelImpl args check bug #9651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2022
Merged

ManagedChannelImpl.SubchannelImpl args check bug #9651

merged 5 commits into from
Nov 11, 2022

Conversation

CLFutureX
Copy link
Contributor

@CLFutureX CLFutureX commented Oct 22, 2022 •
edited
Loading

@CLFutureX CLFutureX closed this Oct 22, 2022
@CLFutureX CLFutureX reopened this Oct 22, 2022
@CLFutureX CLFutureX marked this pull request as draft October 23, 2022 02:34
@CLFutureX CLFutureX marked this pull request as ready for review October 23, 2022 02:35
@CLFutureX CLFutureX closed this Oct 24, 2022
@CLFutureX CLFutureX reopened this Oct 24, 2022
@CLFutureX CLFutureX closed this Oct 24, 2022
@CLFutureX CLFutureX reopened this Oct 24, 2022
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 1, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 1, 2022
@ejona86 ejona86 requested a review from sanjaypujare November 10, 2022 21:10
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 10, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 10, 2022
sanjaypujare
sanjaypujare approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 096898a into grpc:master Nov 11, 2022
@ejona86 ejona86 mentioned this pull request Nov 11, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@sanjaypujare sanjaypujare sanjaypujare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CLFutureX @ejona86 @sanjaypujare @grpc-kokoro