xds: generic xds client #9444
Merged
xds: generic xds client #9444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
reviewed
Sep 6, 2022
ejona86
reviewed
Sep 15, 2022
| private String rdsVersion = ""; | ||
| private String cdsVersion = ""; | ||
| private String edsVersion = ""; | ||
| private final Map<ResourceType, String> versions = new HashMap<>(); |
There was a problem hiding this comment.
FWIW, it looks trivial to use XdsResourceType as the key here (and the other map with ResourceType as the key). I did see the TODO for ResourceType, and that's okay, I just noticed those two maps seemed trivial.
ejona86
approved these changes
Sep 16, 2022
apolcyn
added a commit
to apolcyn/grpc-java
that referenced
this pull request
Sep 22, 2022
)" This reverts commit e1ad984.
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Oct 6, 2022
Mainly refactor work to make type specific xds resources generic, e.g. 1. Define abstract class XdsResourceType to be extended by pluggable new resources. It mainly contains abstract method doParse() to parse unpacked proto messges and produce a ResourceUpdate. The common unpacking proto logic is in XdsResourceType default method parse() 2. Move the parsing/processing logics to specific XdsResourceType. Implementing: XdsListenerResource for LDS XdsRouteConfigureResource for RDS XdsClusterResource for CDS XdsEndpointResource for EDS 3. The XdsResourceTypes are singleton. To process for each XdsClient, context is passed in parameters, defined by XdsResourceType.Args. 4. Watchers will use generic APIs to subscribe to resource watchXdsResource(XdsResourceType, resourceName, watcher). Watcher and ResourceSubscribers becomes java generic class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of type specific xds resources but making it generic, e.g.
XdsResourceTypeto be extended by pluggable new resources. It mainly contains abstract methoddoParse()to parse unpacked proto messges and produce aResourceUpdate. The common unpacking proto logic is inXdsResourceTypedefault methodparse()XdsResourceType. Implementing:XdsListenerResourcefor LDSXdsRouteConfigureResourcefor RDSXdsClusterResourcefor CDSXdsEndpointResourcefor EDSXdsResourceTypes are singleton. To process for eachXdsClient, context is passed in parameters, defined byXdsResourceType.Args.watchXdsResource(XdsResourceType, resourceName, watcher). Watcher and ResourceSubscribers becomes java generic class.