Skip to content

xds: xDS-based HTTP CONNECT configuration #11861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2025
Merged

xds: xDS-based HTTP CONNECT configuration #11861

merged 10 commits into from
Mar 6, 2025

Conversation

shivaspeaks
Copy link
Member

@shivaspeaks shivaspeaks commented Jan 29, 2025 •
edited
Loading

Implements gRFC A86 (grpc/proposal#455).

@shivaspeaks shivaspeaks requested a review from ejona86 January 29, 2025 13:40
ejona86
ejona86 reviewed Jan 29, 2025
View reviewed changes
@shivaspeaks shivaspeaks requested a review from ejona86 January 30, 2025 19:30
@shivaspeaks shivaspeaks requested a review from ejona86 February 1, 2025 01:56
ejona86
ejona86 reviewed Feb 6, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there's a TODO in the comment, but I'm OOO tomorrow so I might at least share what meager comments I have. You can wait until I finisher the fuller review.

@shivaspeaks shivaspeaks requested a review from ejona86 February 17, 2025 10:33
@shivaspeaks
Copy link
Member Author

Please react on this comment (👍) if this looks good, and then I will proceed with unit tests. Except the class cast discussion.

@ejona86 ejona86 removed their request for review February 26, 2025 00:40
@shivaspeaks shivaspeaks requested a review from ejona86 March 3, 2025 13:32
ejona86
ejona86 reviewed Mar 4, 2025
View reviewed changes
@shivaspeaks shivaspeaks requested a review from ejona86 March 5, 2025 18:19
@shivaspeaks shivaspeaks merged commit 1219706 into grpc:master Mar 6, 2025
15 of 16 checks passed
@shivaspeaks shivaspeaks deleted the xds_http_connect branch March 6, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shivaspeaks @ejona86