core: Alternate ipV4 and ipV6 addresses for Happy Eyeballs in PickFirstLeafLoadBalancer #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Oct 21, 2024
| } | ||
|
|
||
| private static final class InterleavedEntry { | ||
| private final int addressGroup; |
There was a problem hiding this comment.
Just store Attributes directly.
| } | ||
|
|
||
| private static final class IndexHappyEyeballs implements Index { | ||
| private List<EquivalentAddressGroup> addressGroups; |
There was a problem hiding this comment.
We don't need the original EAGs any more.
| interface Index { | ||
| static Index create(List<EquivalentAddressGroup> groups) { | ||
| if (PickFirstLoadBalancerProvider.isEnabledHappyEyeballs()) { | ||
| return new IndexHappyEyeballs(groups); |
There was a problem hiding this comment.
I don't see why we need two implementations. We can flatten the EAGs all the time, and for Happy Eyeballs do the extra interleaving. Only the interleaving needs to be different. I don't want to duplicate this wide API surface just for interleaving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRFC A61 states that addresses should be alternated in the Happy Eyeballs case rather than purely going in the specified order.