Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Import RLQS protos #11418

Merged
merged 4 commits into from
Aug 2, 2024
Merged

xds: Import RLQS protos #11418

merged 4 commits into from
Aug 2, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Jul 29, 2024

Imports the protos of Rate Limiting Quota Service (RLQS) and Rate Limit Quota HTTP Filter.

Note: the list below only shows the new top-level protos, and excludes their direct and transitional dependencies (those from import statements).

RLQS Imports

  • Service — envoy/service/rate_limit_quota/v3/rlqs.proto (Service): 7b8a304
  • HTTP Filter — envoy/extensions/filters/http/rate_limit_quota/v3/rate_limit_quota.proto: 49c77c4

CEL Imports

  • Initial third-party repo setup: 99a64bd
  • Parsed CEL Expression: cel/expr/syntax.proto: 99a64bd
  • Parsed and type-checked CEL Expression: cel/expr/checked.proto: 99a64bd

Required typed_config extensions

bucket_matchers predicate input
  • HttpAttributesCelMatchInput — xds/type/matcher/v3/http_inputs.proto: 54924e0
  • HttpRequestHeaderMatchInput — envoy/type/matcher/v3/http_inputs.proto: 49c77c4
bucket_matchers predicate custom_match
  • CelMatcher — xds/type/matcher/v3/cel.proto: 54924e0

@sergiitk sergiitk force-pushed the xds-add-rlqs-protos branch from 0a0575b to 7b8a304 Compare July 30, 2024 19:21
http_inputs.proto provides HttpRequestHeaderMatchInput, which can be
used as a typed config in `bucket_matchers` predicate input.
@sergiitk sergiitk force-pushed the xds-add-rlqs-protos branch from 8677277 to 49c77c4 Compare July 30, 2024 22:50
@sergiitk sergiitk force-pushed the xds-add-rlqs-protos branch from c7c6046 to 99a64bd Compare July 31, 2024 01:35
http_inputs.proto provides HttpAttributesCelMatchInput, which can be
used as a typed config in `bucket_matchers` predicate input.
@sergiitk sergiitk marked this pull request as ready for review July 31, 2024 22:13
@sergiitk sergiitk requested a review from ejona86 July 31, 2024 22:13
@sergiitk sergiitk merged commit c29763d into grpc:master Aug 2, 2024
15 checks passed
@sergiitk sergiitk deleted the xds-add-rlqs-protos branch August 2, 2024 17:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants