Skip to content

Commit ebb43a6

Browse files
authored
Add "#server" as dataplane target value for xDS enabled gRPC servers. (#11715)
As mentioned in [A71 xDS Fallback]( https://github.com/grpc/proposal/blob/master/A71-xds-fallback.md#update-csds-to-aggregate-configs-from-multiple-xdsclient-instances): updated dataplane target to "#server" for xDS-enabled gRPC servers.
1 parent 0192bec commit ebb43a6

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

xds/src/main/java/io/grpc/xds/XdsServerWrapper.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,7 @@ public void run() {
172172

173173
private void internalStart() {
174174
try {
175-
// TODO(dnvindhya): Add "#server" as "grpc.target" attribute value for
176-
// xDS enabled servers.
177-
xdsClientPool = xdsClientPoolFactory.getOrCreate("", new MetricRecorder() {});
175+
xdsClientPool = xdsClientPoolFactory.getOrCreate("#server", new MetricRecorder() {});
178176
} catch (Exception e) {
179177
StatusException statusException = Status.UNAVAILABLE.withDescription(
180178
"Failed to initialize xDS").withCause(e).asException();

0 commit comments

Comments
 (0)