Skip to content

stats/opentelemetry: fix trace attributes message sequence numbers to start from 0 #8237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Apr 8, 2025

As per https://github.com/grpc/proposal/blob/master/A72-open-telemetry-tracing.md sequence-number starts at 0.

RELEASE NOTES:

  • stats/opentelemetry: fix trace attributes message sequence numbers to start from 0.

@yashykt yashykt requested a review from purnesh42H April 8, 2025 19:35
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (6bfa0ca) to head (6e6b327).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8237      +/-   ##
==========================================
- Coverage   82.27%   82.25%   -0.02%     
==========================================
  Files         412      412              
  Lines       40491    40491              
==========================================
- Hits        33312    33305       -7     
- Misses       5824     5832       +8     
+ Partials     1355     1354       -1     
Files with missing lines Coverage Δ
stats/opentelemetry/trace.go 87.50% <100.00%> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@purnesh42H purnesh42H changed the title [OTel Tracing] Message sequence numbers start at 0 stats/opentelemetry: fix trace attributes message sequence numbers to start from 0 Apr 9, 2025
@purnesh42H purnesh42H added Type: Bug Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability labels Apr 9, 2025
@purnesh42H purnesh42H added this to the 1.72 Release milestone Apr 9, 2025
@purnesh42H purnesh42H self-assigned this Apr 9, 2025
@purnesh42H purnesh42H merged commit 732f3f3 into grpc:master Apr 9, 2025
15 checks passed
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Apr 13, 2025
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Apr 15, 2025
This was referenced Apr 15, 2025
purnesh42H added a commit that referenced this pull request Apr 15, 2025
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Observability Includes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP Observability Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants