Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Mar 5, 2025

In #7970, the alts client was changed from using grpc.Dial with grpc.WithBlock to grpc.NewClient without WithBlock. The tests that run in g3 don't wait for the server to start before starting the client. If WithBlock is not used, the client enters TRANSIENT_FAILURE after getting a connection refused error in the first connection attempt. This PR adds grpc.WaitForReady while making the RPC to restore the previous behaviour.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.72 Release milestone Mar 5, 2025
@codecov
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (7505bf2) to head (a11f532).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8141      +/-   ##
==========================================
- Coverage   82.32%   82.26%   -0.07%     
==========================================
  Files         388      389       +1     
  Lines       39016    39125     +109     
==========================================
+ Hits        32121    32187      +66     
- Misses       5574     5607      +33     
- Partials     1321     1331      +10     

see 31 files with indirect coverage changes

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arjan-bal arjan-bal merged commit 0914bba into grpc:master Mar 5, 2025
14 of 15 checks passed
@arjan-bal arjan-bal deleted the fix-alts-interop branch March 5, 2025 07:07
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Mar 24, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants