deps: update dependencies for all modules #7987
Conversation
eshitachandwani
added
the
Type: Dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7987 +/- ##
==========================================
+ Coverage 82.00% 82.06% +0.06%
==========================================
Files 381 381
Lines 38539 38539
==========================================
+ Hits 31602 31627 +25
+ Misses 5612 5593 -19
+ Partials 1325 1319 -6 |
go.mod
Outdated
| go 1.22 | ||
| go 1.22.0 | ||
|
|
||
| toolchain go1.23.4 |
There was a problem hiding this comment.
How did this get added? Is is due to a dependency specifying this or does it come from your locally installed toolchain?
There was a problem hiding this comment.
We need to support go.1.22 until go1.24 is released. I think we should restrict the go and toolchain directives to use strictly less than 1.23.
There was a problem hiding this comment.
It got added automatically when running the script. It gets added when running go mod for go version higher than v1.21 , but it is not necessary and if not present will be assumed to have version same as mentioned in go line above. So I am removing it.
|
I just merged #7974, can you please rebase and re-run the script? |
eshitachandwani
force-pushed
the
branchcut1.70
branch
from
e4f001c to
2d4daf3
Compare
gcp/observability/go.mod
Outdated
| @@ -1,64 +1,65 @@ | |||
| module google.golang.org/grpc/gcp/observability | |||
|
|
|||
| go 1.22 | |||
| go 1.22.7 | |||
There was a problem hiding this comment.
$ grep -ra "go 1.22.7" "$HOME/go/pkg/mod" --include="go.mod"
<omitted>/go/pkg/mod/google.golang.org/grpc/stats/opentelemetry@v0.0.0-20241028142157-ada6787
961b3/go.mod:go 1.22.7
<omitted>/go/pkg/mod/google.golang.org/grpc/reflection/test@v0.0.0-20241010040347-00b9e140ce7
1/go.mod:go 1.22.7
<omitted>/go/pkg/mod/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelg
rpc@v0.58.0/go.mod:go 1.22.7
The reason for the dependency bump is opentelemetry. They updated to grpc-go 1.68.0 due to which they got the minor version in their go.mod files: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6306/files
The minor version was dropped in grpc-go 1.68.1. I think we should ask them to remove the minor version as well.
There was a problem hiding this comment.
I've raised open-telemetry/opentelemetry-go-contrib#6595 on the Otel repo.
There was a problem hiding this comment.
Can you use a lower version of go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc for now?
There was a problem hiding this comment.
Okay, changed the version of go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelg to v0.56.0 as grpc-go 1.68.0 was introduced in v0.57.0
There was a problem hiding this comment.
Thanks, I've opened #8002 to track the version bump of this module.
RELEASE NOTES: None