Skip to content

deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 #7974

merged 1 commit into from
Jan 10, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 30, 2024 •
edited
Loading

Description

This updates github.com/envoyproxy/go-control-plane to v0.13.4 and import new github.com/envoyproxy/go-control-plane/envoy module

Related to envoyproxy/go-control-plane#1074

RELEASE NOTES: None

@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch 4 times, most recently from 8fa3f25 to f45d96d Compare December 30, 2024 08:39
@mmorel-35 mmorel-35 marked this pull request as draft December 30, 2024 08:43
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (724f450) to head (64d6914).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7974      +/-   ##
==========================================
- Coverage   82.28%   82.03%   -0.26%     
==========================================
  Files         381      381              
  Lines       38539    38539              
==========================================
- Hits        31712    31614      -98     
- Misses       5535     5602      +67     
- Partials     1292     1323      +31

see 30 files with indirect coverage changes

@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch 2 times, most recently from ba95fb4 to a55b2ed Compare December 30, 2024 21:19
@mmorel-35 mmorel-35 marked this pull request as ready for review December 30, 2024 21:29
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch 5 times, most recently from 16b8025 to 12f1107 Compare December 30, 2024 21:47
arjan-bal
arjan-bal reviewed Jan 2, 2025
View reviewed changes
@arjan-bal arjan-bal mentioned this pull request Jan 2, 2025
Closed
@purnesh42H purnesh42H added the Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. label Jan 2, 2025
@arjan-bal arjan-bal added the Type: Dependencies Updating/adding/removing dependencies label Jan 3, 2025
@arjan-bal arjan-bal added this to the 1.70 Release milestone Jan 3, 2025
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch 3 times, most recently from b285016 to c9b5007 Compare January 7, 2025 09:04
@mmorel-35 mmorel-35 changed the title deps: bump github.com/envoyproxy/go-control-plane to v0.13.2 deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 Jan 7, 2025
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch from c9b5007 to 0f3ba07 Compare January 7, 2025 09:07
@mmorel-35 mmorel-35 marked this pull request as draft January 8, 2025 06:23
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch 5 times, most recently from 28eb49d to dc3feff Compare January 8, 2025 20:52
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch from 8ad2db6 to fcaf085 Compare January 8, 2025 21:06
@mmorel-35 mmorel-35 marked this pull request as ready for review January 8, 2025 21:13
@mmorel-35 mmorel-35 requested a review from arjan-bal January 8, 2025 21:14
arjan-bal
arjan-bal reviewed Jan 8, 2025
View reviewed changes
scripts/vet.sh Outdated
Metadata is deprecated: use Attributes instead.
Metadata is deprecated:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this needed? The deprecation message is still the same:

grpc-go/resolver/resolver.go

Line 119 in 6f41085

// Deprecated: use Attributes instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a deprecation on GetMetadata that is not caught otherwise

Copy link
Contributor Author

@mmorel-35 mmorel-35 Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, would you be open to use golangci-lint to simplify linters maintenance ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new deprecation is coming from envoy/config/rbac/v3/rbac.proto.

I think we should add a new entry instead of relaxing this pattern to avoid accidentally hiding other deprecation warnings in the future.

GetMetadata is deprecated: Marked as deprecated in envoy/config/rbac

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, would you be open to use golangci-lint to simplify linters maintenance ?

I think we've been able to achieve what we need using vet and staticcheck directly combined with regexes, so there wasn't a need to add a new dependency. If you think think using golangci-lint has significant benefits, please do file an issue and we can discuss this.

@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch from fcaf085 to fd1e67f Compare January 8, 2025 22:37
@mmorel-35 mmorel-35 requested a review from arjan-bal January 8, 2025 22:55
arjan-bal
arjan-bal reviewed Jan 9, 2025
View reviewed changes
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch from fd1e67f to e56bba9 Compare January 9, 2025 06:31
@mmorel-35
deps: bump github.com/envoyproxy/go-control-plane to v0.13.4
64d6914 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the github.com/envoyproxy/go-control-plane@1.13.2 branch from e56bba9 to 64d6914 Compare January 9, 2025 06:33
arjan-bal
arjan-bal approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding another reviewers for a second approval.

@arjan-bal arjan-bal assigned easwars and unassigned mmorel-35 Jan 9, 2025
@arjan-bal arjan-bal requested review from easwars and removed request for easwars January 9, 2025 08:12
@arjan-bal arjan-bal assigned dfawley and unassigned easwars Jan 9, 2025
@arjan-bal arjan-bal requested a review from dfawley January 9, 2025 08:15
@mmorel-35 mmorel-35 mentioned this pull request Jan 9, 2025
Closed
dfawley
dfawley reviewed Jan 9, 2025
View reviewed changes
examples/go.mod
@@ -43,7 +43,7 @@ require (
github.com/beorn7/perks v1.0.1 // indirect
github.com/census-instrumentation/opencensus-proto v0.4.1 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/envoyproxy/go-control-plane v0.13.1 // indirect
github.com/envoyproxy/go-control-plane/envoy v1.32.3 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm extremely happy to see a v1 here -- thanks!!)

@dfawley dfawley assigned arjan-bal and unassigned dfawley Jan 9, 2025
@arjan-bal arjan-bal merged commit 9223fd6 into grpc:master Jan 10, 2025
14 of 15 checks passed
@arjan-bal arjan-bal mentioned this pull request Jan 10, 2025
Merged
@mmorel-35 mmorel-35 deleted the github.com/envoyproxy/go-control-plane@1.13.2 branch January 10, 2025 06:02
@Fank Fank mentioned this pull request Jan 14, 2025
Closed
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Jan 26, 2025
@mmorel-35 @janardhankrishna-sai
deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 (grpc#7974)
a8c0394 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 13, 2025
@mmorel-35 @janardhankrishna-sai
deps: bump github.com/envoyproxy/go-control-plane to v0.13.4 (grpc#7974)
f17ad2a 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfawley dfawley dfawley approved these changes

@arjan-bal arjan-bal arjan-bal approved these changes

Assignees

@arjan-bal arjan-bal

Labels
Area: Tooling Includes anything related to Go builds, modules etc and includes Releases & Github Workflows. Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.70 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorel-35 @dfawley @arjan-bal @easwars @purnesh42H