-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental/stats: re-add type aliases for migration #7929
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7929 +/- ##
==========================================
- Coverage 82.10% 82.02% -0.09%
==========================================
Files 378 379 +1
Lines 38258 38260 +2
==========================================
- Hits 31412 31382 -30
- Misses 5547 5566 +19
- Partials 1299 1312 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix @dfawley
Will this be cherry-picked into a patch release for 1.69, or will this land in 1.70? |
Yes, it will go into the 1.69.2 release very soon. |
@bjohnso5 1.69.2 release is published |
#7874 removed symbols without leaving behind type aliases, which we should not do. This change re-adds the things removed and should be kept for several releases.
(No release notes since it will be in a patch release.)
RELEASE NOTES: none