Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental/stats: re-add type aliases for migration #7929

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Dec 13, 2024

#7874 removed symbols without leaving behind type aliases, which we should not do. This change re-adds the things removed and should be kept for several releases.

(No release notes since it will be in a patch release.)

RELEASE NOTES: none

@dfawley dfawley added this to the 1.69 Release milestone Dec 13, 2024
@dfawley dfawley requested a review from zasweq December 13, 2024 16:38
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.02%. Comparing base (38a8b9a) to head (faf18cd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
experimental/stats/metrics.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7929      +/-   ##
==========================================
- Coverage   82.10%   82.02%   -0.09%     
==========================================
  Files         378      379       +1     
  Lines       38258    38260       +2     
==========================================
- Hits        31412    31382      -30     
- Misses       5547     5566      +19     
- Partials     1299     1312      +13     
Files with missing lines Coverage Δ
experimental/stats/metrics.go 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

Copy link

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @dfawley

@easwars easwars assigned dfawley and unassigned purnesh42H and zasweq Dec 13, 2024
@dfawley dfawley merged commit 7ee073d into grpc:master Dec 13, 2024
15 checks passed
@dfawley dfawley deleted the alias branch December 13, 2024 19:24
@bjohnso5
Copy link

Will this be cherry-picked into a patch release for 1.69, or will this land in 1.70?

purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Dec 18, 2024
@purnesh42H purnesh42H mentioned this pull request Dec 18, 2024
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Dec 18, 2024
purnesh42H pushed a commit to purnesh42H/grpc-go that referenced this pull request Dec 18, 2024
@dfawley
Copy link
Member Author

dfawley commented Dec 18, 2024

Will this be cherry-picked into a patch release for 1.69, or will this land in 1.70?

Yes, it will go into the 1.69.2 release very soon.

@purnesh42H
Copy link
Contributor

@bjohnso5 1.69.2 release is published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants