Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environment variable, rather than parsing from bootstrap file #7740

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Oct 14, 2024

This PR switches the mesh_id local label to get set from the CSM_MESH_ID environment variable, with the same logic as other labels set from the environment. It no longer comes from the bootstrap, or needs to be parsed from the node_id of the bootstrap.

RELEASE NOTES:

  • stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environment variable, rather than parsing from bootstrap file

@zasweq zasweq requested a review from dfawley October 14, 2024 19:04
@zasweq zasweq added the Type: Behavior Change Behavior changes not categorized as bugs label Oct 14, 2024
@zasweq zasweq added this to the 1.68 Release milestone Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (ad81c20) to head (7a731cb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7740      +/-   ##
==========================================
+ Coverage   82.07%   82.09%   +0.02%     
==========================================
  Files         362      362              
  Lines       28116    28116              
==========================================
+ Hits        23075    23081       +6     
- Misses       3839     3842       +3     
+ Partials     1202     1193       -9     

see 19 files with indirect coverage changes

@purnesh42H
Copy link
Contributor

purnesh42H commented Oct 15, 2024

stats/opentelemetry/csm: Get mesh_id local label from "CSM_MESH_ID" environment variable, rather than parsing from bootstrap file

Not fully familiar with the background on this but for now should we keep both parsing from bootstrap and env var for backward compatibility?

@zasweq
Copy link
Contributor Author

zasweq commented Oct 15, 2024

No not in this case, as we are getting rid of the old way entirely.

@zasweq
Copy link
Contributor Author

zasweq commented Oct 15, 2024

Interop tests passed.

@zasweq zasweq merged commit 54841ef into grpc:master Oct 15, 2024
15 checks passed
sagarsudo pushed a commit to sagarsudo/grpc-go that referenced this pull request Oct 16, 2024
…environment variable, rather than parsing from bootstrap file (grpc#7740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants