-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mem: replace flate.Reader reference #7595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7595 +/- ##
==========================================
+ Coverage 81.87% 81.88% +0.01%
==========================================
Files 361 361
Lines 27813 27813
==========================================
+ Hits 22773 22776 +3
- Misses 3843 3846 +3
+ Partials 1197 1191 -6
|
dfawley
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @PapaCharlie
Yep makes sense to me! |
easwars
approved these changes
Sep 11, 2024
purnesh42H
approved these changes
Sep 11, 2024
dfawley
added
Type: Dependencies
Updating/adding/removing dependencies
and removed
Type: Internal Cleanup
Refactors, etc
labels
Sep 11, 2024
purnesh42H
pushed a commit
to purnesh42H/grpc-go
that referenced
this pull request
Sep 11, 2024
dfawley
pushed a commit
that referenced
this pull request
Sep 11, 2024
arjan-bal
pushed a commit
to arjan-bal/grpc-go
that referenced
this pull request
Sep 17, 2024
arjan-bal
added a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface has nothing to do with compression and there are no other references to that package in the codebase. If we remove the reference we same compiler and linker some work - no need to parse, compile, link that package just to use one interface from it (assuming no other references from the codebase).
RELEASE NOTES:
compress/flate
package