.*: fix revive package-comments lint issues #7574
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7574 +/- ##
==========================================
+ Coverage 81.76% 81.87% +0.11%
==========================================
Files 361 361
Lines 27825 27809 -16
==========================================
+ Hits 22752 22770 +18
+ Misses 3866 3847 -19
+ Partials 1207 1192 -15 |
| @@ -16,6 +16,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
| // Binary client is an example client. | |||
There was a problem hiding this comment.
Can you include the example's purpose/name here too? E.g.
// Binary client is an example client for CSM observability.
There was a problem hiding this comment.
Added. Should we change other examples as well? I just followed the other examples and they didn't have names
There was a problem hiding this comment.
The goal is not to increase the scope of this work. I'm fine with leaving existing things alone -- unless you want to go change them, in which case I will approve.
In general, though, we should never use "some other thing we have does X" as an excuse to do "X", if we know "X" is not optimal.
There was a problem hiding this comment.
I agree. I was just not sure if it was intentional to leave out the names.
purnesh42H
force-pushed
the
fix-revive-package-comments-lints
branch
from
150705e to
8829742
Compare
purnesh42H
force-pushed
the
fix-revive-package-comments-lints
branch
from
8829742 to
acb5a77
Compare
| @@ -16,6 +16,7 @@ | |||
| * | |||
| */ | |||
|
|
|||
| // Binary client is an example client for custom load balancer. | |||
There was a problem hiding this comment.
This is not proper English. "for a custom load balancer" or "a client for the custom load balancer example", etc.
Addresses: #7444
RELEASE NOTES: None