vet: dont revive from revive

[arvindbr8]

I would prefer if we took this approach with revive + #7444. This way we can re-enable each of the check as in when we fix them. This gives us a better way of testing changes like #7528

Let me know how you think about this

RELEASE NOTES: none

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.89%. Comparing base (1e2bb71) to head (c3b52c1).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7543      +/-   ##
==========================================
- Coverage   81.94%   81.89%   -0.05%     
==========================================
  Files         360      360              
  Lines       27509    27508       -1     
==========================================
- Hits        22542    22528      -14     
- Misses       3777     3789      +12     
- Partials     1190     1191       +1     

see 24 files with indirect coverage changes

[arvindbr8]

@purnesh42H -- I want to take a look at https://github.com/mgechev/revive#available-rules and see if there are some more rules we would love to include which are not part of the default set.

also staticcheck might already be doing some of this... ugh, why did golint have to go away

[purnesh42H]

@arvindbr8 Just to confirm the rules mentioned in .toml file are disabled and rest of the rules are enabled by default? or we will only check for rules which are in .toml file?

I think former is better to exclude the rules which we don't want and let everything else being checked. In my PR https://github.com/grpc/grpc-go/pull/7472/files#diff-68ca30ee8b2dba2db2f3c93ad8d56c67f4dab2bd4475848f24f70c41f4681f22R177 i had only excluded unused-parameter as there were so many. Initial plan was to enforce revive once everything except unused-parameter is fixed, which should be quick

[arvindbr8]

Spoke to @purnesh42H offline. Seems like PRs for all the checks are in flight. We dont have to bother working on a revive config at this point.

Just to confirm the rules mentioned in .toml file are disabled and rest of the rules are enabled by default

The default set of checks does not contain all the rules. There is an option to enable all rules. I think it's still worth exploring other linters. tbh, we only care if golint passes.

Again, ugh.. why did they deprecate OSS golint :/