-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Use builtin min and max functions #7478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Go added builtin min and max functions in 1.21. This commit removes existing functions and uses the built-ins in stead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7478 +/- ##
==========================================
+ Coverage 81.40% 81.44% +0.04%
==========================================
Files 357 357
Lines 27243 27233 -10
==========================================
+ Hits 22176 22180 +4
+ Misses 3850 3833 -17
- Partials 1217 1220 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you mind reverting the unrelated changes please?
With the upgrade to Go 1.21 (#7282), grpc-go can use the new builtin min and max functions. This commit removes existing functions and uses the built-ins instead.
RELEASE NOTES: none