Skip to content

Use builtin min and max functions #7478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

jhalterman
Copy link
Contributor

@jhalterman jhalterman commented Aug 4, 2024

With the upgrade to Go 1.21 (#7282), grpc-go can use the new builtin min and max functions. This commit removes existing functions and uses the built-ins instead.

RELEASE NOTES: none

Go added builtin min and max functions in 1.21. This commit removes existing functions and uses the built-ins in stead.
Copy link

linux-foundation-easycla bot commented Aug 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (e524655) to head (1e146b1).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7478      +/-   ##
==========================================
+ Coverage   81.40%   81.44%   +0.04%     
==========================================
  Files         357      357              
  Lines       27243    27233      -10     
==========================================
+ Hits        22176    22180       +4     
+ Misses       3850     3833      -17     
- Partials     1217     1220       +3     
Files Coverage Δ
balancer/rls/internal/adaptive/lookback.go 100.00% <ø> (ø)
credentials/alts/internal/conn/record.go 84.69% <ø> (-0.61%) ⬇️
internal/channelz/channelmap.go 89.89% <ø> (-0.21%) ⬇️
internal/transport/controlbuf.go 89.82% <ø> (+0.34%) ⬆️
internal/transport/http2_client.go 91.82% <100.00%> (-0.43%) ⬇️
internal/transport/http2_server.go 91.10% <100.00%> (ø)
xds/internal/balancer/outlierdetection/balancer.go 88.58% <ø> (+0.24%) ⬆️

... and 17 files with indirect coverage changes

@purnesh42H purnesh42H self-assigned this Aug 6, 2024
@purnesh42H purnesh42H added the Type: Dependencies Updating/adding/removing dependencies label Aug 7, 2024
@purnesh42H purnesh42H added this to the 1.66 Release milestone Aug 7, 2024
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for the contribution!

@purnesh42H purnesh42H assigned dfawley and unassigned purnesh42H Aug 7, 2024
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do you mind reverting the unrelated changes please?

@arvindbr8 arvindbr8 assigned jhalterman and unassigned dfawley Aug 8, 2024
@arvindbr8 arvindbr8 added Status: Requires Reporter Clarification Type: Internal Cleanup Refactors, etc and removed Type: Dependencies Updating/adding/removing dependencies labels Aug 8, 2024
@aranjans aranjans assigned dfawley and unassigned jhalterman Aug 13, 2024
@arjan-bal arjan-bal modified the milestones: 1.66 Release, 1.67 Release Aug 16, 2024
@purnesh42H purnesh42H merged commit 6a5a283 into grpc:master Aug 20, 2024
13 checks passed
@jhalterman jhalterman deleted the remove-min-function branch September 14, 2024 23:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants