-
Notifications
You must be signed in to change notification settings - Fork 4.5k
grpclog: remove Debugf method to avoid unnecessary evaluation #7330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is one remaining reference in a comment: grpc-go/xds/internal/xdsclient/transport/transport.go Lines 49 to 52 in c04b085
|
@atollena I removed the reference in the comment and amended the changes into the first commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryuryu08 Thanks for the PR. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes: #7154
RELEASE NOTES: none