Skip to content

grpclog: remove Debugf method to avoid unnecessary evaluation #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ryuryu08
Copy link
Contributor

Fixes: #7154

RELEASE NOTES: none

@ryuryu08
Copy link
Contributor Author

cc @aranjans @dfawley

@atollena
Copy link
Collaborator

There is one remaining reference in a comment:

// Any per-RPC level logs which print complete request or response messages
// should be gated at this verbosity level. Other per-RPC level logs which print
// terse output should be at `INFO` and verbosity 2, which corresponds to using
// the `Debugf` method on the logger.

@ryuryu08
Copy link
Contributor Author

ryuryu08 commented Jun 19, 2024

There is one remaining reference in a comment:

// Any per-RPC level logs which print complete request or response messages
// should be gated at this verbosity level. Other per-RPC level logs which print
// terse output should be at `INFO` and verbosity 2, which corresponds to using
// the `Debugf` method on the logger.

@atollena I removed the reference in the comment and amended the changes into the first commit.

@aranjans aranjans added the Type: Internal Cleanup Refactors, etc label Jun 21, 2024
@aranjans aranjans added this to the 1.66 Release milestone Jun 23, 2024
Copy link
Contributor

@aranjans aranjans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryuryu08 Thanks for the PR. LGTM!

@aranjans aranjans assigned purnesh42H and unassigned aranjans Jun 23, 2024
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purnesh42H purnesh42H assigned dfawley and unassigned purnesh42H Jun 24, 2024
@purnesh42H purnesh42H added Type: Bug and removed Type: Internal Cleanup Refactors, etc labels Jun 24, 2024
@purnesh42H purnesh42H requested a review from dfawley June 24, 2024 09:31
@dfawley dfawley added Type: Internal Cleanup Refactors, etc and removed Type: Bug labels Jun 24, 2024
@dfawley dfawley merged commit 8c80220 into grpc:master Jun 24, 2024
11 checks passed
@ryuryu08 ryuryu08 deleted the ryuryu08_7154 branch June 25, 2024 02:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete grpclog's Debugf function
5 participants