reflection: rename non-regenerated pb.go files to not be called '.pb.go' #6885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6885 +/- ##
==========================================
- Coverage 83.79% 83.75% -0.04%
==========================================
Files 286 286
Lines 30792 30792
==========================================
- Hits 25801 25789 -12
- Misses 3942 3950 +8
- Partials 1049 1053 +4 |
easwars
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to stop importing any generated code (to use proto build rules instead), but need to continue to import these files. So renaming them will make them not match a "**/*.pb.go" exclude filter.
RELEASE NOTES: n/a