Skip to content

grpc: add a warning for unsupported codec #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

grpc: add a warning for unsupported codec #6658

merged 1 commit into from
Oct 13, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 22, 2023

RELEASE NOTES:

  • grpc: add a warning message for unsupported codecs; will stop defaulting to proto codec in a future release

@easwars easwars requested a review from dfawley September 22, 2023 20:06
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Sep 22, 2023
@easwars easwars added this to the 1.59 Release milestone Sep 22, 2023
dfawley
dfawley reviewed Sep 25, 2023
View reviewed changes
@dfawley dfawley assigned easwars and unassigned dfawley Sep 25, 2023
@dfawley
Copy link
Member

dfawley commented Sep 25, 2023

One more thing: let's add a test where the client uses an unregistered codec on the server if one doesn't already exist.

@easwars
Copy link
Contributor Author

easwars commented Sep 25, 2023

One more thing: let's add a test where the client uses an unregistered codec on the server if one doesn't already exist.

Will add one. The codec tests in our e2e tests are a little bit of a mess. I will clean them up in a separate PR and then will add the test here.

@ginayeh ginayeh modified the milestones: 1.59 Release, 1.60 Release Oct 5, 2023
@easwars easwars mentioned this pull request Oct 13, 2023
Closed
@easwars easwars merged commit 2cf5619 into grpc:master Oct 13, 2023
@easwars easwars deleted the unsupported_codec branch October 13, 2023 01:22
@easwars easwars mentioned this pull request Oct 13, 2023
Open
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Nov 7, 2023
@easwars @arvindbr8
grpc: add a warning for unsupported codec (grpc#6658)
ef35356
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@easwars @dfawley @ginayeh