idle: use LB policy close event as a proxy for channel idleness #6628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Sep 13, 2023
internal/idle/idle_e2e_test.go
Outdated
| // Returns a channel that gets pinged when the balancer is closed. | ||
| func registerWrappedRoundRobinPolicy(t *testing.T) chan struct{} { | ||
| rrBuilder := balancer.Get(roundrobin.Name) | ||
| internal.BalancerUnregister(rrBuilder.Name()) |
There was a problem hiding this comment.
This is unnecessary. Just register the new one over the old one.
dfawley
approved these changes
Sep 13, 2023
easwars
force-pushed
the
idle_test_improve_checks
branch
from
77432c8 to
dc8735d
Compare
I thought of the same once I prepared the PR and was going through the diff, before asking for your review :). Added it now. |
dfawley
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing tests were using the absence of a certain log message in channelz to verify that the channel did not enter IDLE (apart from checking the channel connectivity state). But these checks aren't great because if we decided to change the string we log, then the test case will no longer be valid but will continue to pass.
This PR uses the closing of the LB policy as a proxy for channel entering IDLE mode instead.
Fixes #6612
RELEASE NOTES: none